Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random error in with-driver-tests #681

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Oct 7, 2024

Closes #676

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

There is a race condition in Firefox that sometimes results in a
zombie session. When we detect this condition, we throw away the bad
session and create another one.
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dgr, I know that this small change was tied to two tons of testing work; thanks for all the effort!

Lemme know what you think of my comments.

src/etaoin/api.clj Outdated Show resolved Hide resolved
src/etaoin/api.clj Outdated Show resolved Hide resolved
src/etaoin/api.clj Outdated Show resolved Hide resolved
src/etaoin/api.clj Outdated Show resolved Hide resolved
src/etaoin/api.clj Show resolved Hide resolved
src/etaoin/api.clj Show resolved Hide resolved
src/etaoin/api.clj Outdated Show resolved Hide resolved
@lread lread merged commit b4f93eb into clj-commons:master Oct 8, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-676-bad-browser branch October 8, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random error in with-driver-tests
2 participants